cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aweisberg <...@git.apache.org>
Subject [GitHub] cassandra pull request #265: 14705
Date Mon, 10 Sep 2018 19:32:53 GMT
Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/265#discussion_r216445669
  
    --- Diff: src/java/org/apache/cassandra/locator/ReplicaPlan.java ---
    @@ -237,4 +237,17 @@ public int requiredParticipants()
             }
         }
     
    +    /**
    +     * Used by AbstractReadExecutor, {Data,Digest}Resolver and ReadRepair to share a
ReplicaPlan whose 'contact' replicas
    +     * we progressively modify via various forms of speculation (initial speculation,
rr-read and rr-write)
    +     * @param <P>
    +     */
    +    public static class Shared<P extends ReplicaPlan<?, ?, ?>>
    --- End diff --
    
    This is kind of a weird place it end up in terms of mutability and immutability. It's
not thread safe and if it's supposed to be always referencing the latest instance why immutable?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message