cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ifesdjeen <...@git.apache.org>
Subject [GitHub] cassandra pull request #265: 14705
Date Wed, 12 Sep 2018 12:39:58 GMT
Github user ifesdjeen commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/265#discussion_r217012379
  
    --- Diff: src/java/org/apache/cassandra/service/reads/DigestResolver.java ---
    @@ -93,16 +93,14 @@ public PartitionIterator getData()
             {
                 // This path can be triggered only if we've got responses from full replicas
and they match, but
                 // transient replica response still contains data, which needs to be reconciled.
    -            DataResolver<E, L> dataResolver = new DataResolver<>(command,
    -                                                                 replicaLayout,
    -                                                                 (ReadRepair<E, L>)
NoopReadRepair.instance,
    -                                                                 queryStartNanoTime);
    +            DataResolver<E, P> dataResolver
    +                    = new DataResolver<>(command, replicaPlan, (ReadRepair<E,
P>) NoopReadRepair.instance, queryStartNanoTime);
     
                 dataResolver.preprocess(dataResponse);
                 // Forward differences to all full nodes
    --- End diff --
    
    I think this one should be already fixed in CASSANDRA-14698


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message