cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From belliottsmith <...@git.apache.org>
Subject [GitHub] cassandra pull request #265: 14705
Date Wed, 12 Sep 2018 20:22:23 GMT
Github user belliottsmith commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/265#discussion_r217175374
  
    --- Diff: src/java/org/apache/cassandra/service/reads/repair/BlockingReadRepair.java ---
    @@ -53,15 +53,16 @@
         protected final Queue<BlockingPartitionRepair> repairs = new ConcurrentLinkedQueue<>();
         private final int blockFor;
     
    -    BlockingReadRepair(ReadCommand command, P replicaPlan, long queryStartNanoTime)
    +    BlockingReadRepair(ReadCommand command, ReplicaPlan.Shared<P> replicaPlan,
long queryStartNanoTime)
         {
             super(command, replicaPlan, queryStartNanoTime);
    -        this.blockFor = replicaPlan.consistencyLevel().blockFor(cfs.keyspace);
    +        this.blockFor = replicaPlan().consistencyLevel().blockFor(cfs.keyspace);
         }
     
         public UnfilteredPartitionIterators.MergeListener getMergeListener(P replicaPlan)
         {
    -        return new PartitionIteratorMergeListener<>(replicaPlan, command, this.replicaPlan.consistencyLevel(),
this);
    +        // TODO: why are we referencing a different replicaPlan here?
    --- End diff --
    
    I think that was a stale comment.  The merging never modified the replicaPlan, and it
should never be modified during the SRP.  Logically, it should be a snapshot of only the relevant
replicas for the SRP.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message