Github user aweisberg commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/265#discussion_r217185583
--- Diff: src/java/org/apache/cassandra/service/reads/ReadCallback.java ---
@@ -44,16 +43,17 @@
import org.apache.cassandra.utils.FBUtilities;
import org.apache.cassandra.utils.concurrent.SimpleCondition;
-public class ReadCallback<E extends Endpoints<E>, L extends ReplicaLayout<E,
L>> implements IAsyncCallbackWithFailure<ReadResponse>
+public class ReadCallback<E extends Endpoints<E>, P extends ReplicaPlan.ForRead<E>>
implements IAsyncCallbackWithFailure<ReadResponse>
{
protected static final Logger logger = LoggerFactory.getLogger( ReadCallback.class
);
public final ResponseResolver resolver;
final SimpleCondition condition = new SimpleCondition();
private final long queryStartNanoTime;
- // TODO: move to replica layout as well?
- final int blockfor;
- final L replicaLayout;
+ final int blockFor; // TODO: move to replica plan as well?
--- End diff --
Move it or keep it?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
|