cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aweisberg <...@git.apache.org>
Subject [GitHub] cassandra pull request #265: 14705
Date Wed, 12 Sep 2018 20:55:43 GMT
Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/265#discussion_r217185707
  
    --- Diff: src/java/org/apache/cassandra/service/AbstractWriteResponseHandler.java ---
    @@ -189,28 +189,30 @@ public final void expired()
         /**
          * @return the minimum number of endpoints that must reply.
          */
    -    protected int totalBlockFor()
    +    protected int blockFor()
         {
             // During bootstrap, we have to include the pending endpoints or we may fail
the consistency level
             // guarantees (see #833)
    -        return replicaLayout.consistencyLevel().blockForWrite(replicaLayout.keyspace(),
replicaLayout.pending());
    +        return replicaPlan.blockFor();
         }
     
         /**
    +     * TODO: this method is brittle for its purpose of deciding when we should fail a
query;
    --- End diff --
    
    Should this be a JIRA rather than a TODO or just get done?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message