cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jrwest <...@git.apache.org>
Subject [GitHub] cassandra-dtest pull request #37: Add tests for CASSANDRA-14145
Date Tue, 18 Sep 2018 00:35:39 GMT
Github user jrwest commented on a diff in the pull request:

    https://github.com/apache/cassandra-dtest/pull/37#discussion_r218263635
  
    --- Diff: repair_tests/incremental_repair_test.py ---
    @@ -207,6 +208,7 @@ def test_manual_session_fail(self):
             self.fixture_dtest_setup.setup_overrides.cluster_options = ImmutableMapping({'hinted_handoff_enabled':
'false',
                                                                                         
'num_tokens': 1,
                                                                                         
'commitlog_sync_period_in_ms': 500})
    +        self.fixture_dtest_setup.init_default_config()
    --- End diff --
    
    Also I'm not sure its clear to me why `init_default_config()` is called before every test.
Is it because the config changes in the preceding lines weren't actually being picked up prior?



---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message