cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From belliottsmith <...@git.apache.org>
Subject [GitHub] cassandra pull request #269: Review tr range movements
Date Tue, 18 Sep 2018 11:06:26 GMT
Github user belliottsmith commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/269#discussion_r218382891
  
    --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java ---
    @@ -87,8 +85,8 @@
         private final InetAddressAndPort address;
         /* streaming description */
         private final String description;
    -    private final Multimap<String, Multimap<InetAddressAndPort, FetchReplica>>
toFetch = HashMultimap.create();
    -    private final Set<Predicate<Replica>> sourceFilters = new HashSet<>();
    +    private final Map<String, Multimap<InetAddressAndPort, FetchReplica>>
toFetch = new HashMap<>();
    +    private final Set<SourceFilter> sourceFilters = new HashSet<>();
    --- End diff --
    
    Does this need to be a Set?  (I realise this is old, but it doesn't make much sense AFAICT)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message