cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ifesdjeen <...@git.apache.org>
Subject [GitHub] cassandra pull request #269: Review tr range movements
Date Mon, 17 Sep 2018 15:26:26 GMT
GitHub user ifesdjeen opened a pull request:

    https://github.com/apache/cassandra/pull/269

    Review tr range movements

    CASSANDRA-14756

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ifesdjeen/cassandra review-tr-range-movements

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cassandra/pull/269.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #269
    
----
commit e51899d09a254e4a4d86c4fea26b6ada7eaebbcd
Author: Alex Petrov <oleksandr.petrov@...>
Date:   2018-09-17T09:51:56Z

    Enable dtests

commit 60927ae3a8c5c54b273a519110cc4c0540826d48
Author: Alex Petrov <oleksandr.petrov@...>
Date:   2018-09-13T08:39:01Z

    Simplify iteration in calculateRangesToFetchWithPreferredEndpoints
    
    Extract RangeRelocator
    
    Minor changes to calculateRangesToFetchWithPreferredEndpoints to improve readability:
    
      * short-circuit range.contains(), remove one level of nesting
      * remove and use isSufficient instead since it duplicates the source filters that are
already applied (see usages of RangeStreamer.FailureDetectorSourceFilter and ExcludeLocalNodeFilter())
      * use explicit fullness checks instead of “any” check
    
    Simplify RangeRelocator code
    
    Further simplify calculateRangesToStreamWithEndpoints after Benedict’s comment
    
    Fix range relocation
    
    Simplify calculateStreamAndFetchRanges
    
    Unify request/transfer ranges interface (Added benefit of this change is that we have
a check for non-intersecting ranges)
    
    Simplify iteration in calculateRangesToFetchWithPreferredEndpoints
    
    Extract RangeRelocator
    Simplify RangeRelocator code
    
    Minor changes to calculateRangesToFetchWithPreferredEndpoints to improve readability:
    
      * short-circuit range.contains(), remove one level of nesting
      * remove and use isSufficient instead since it duplicates the source filters that are
already applied (see usages of RangeStreamer.FailureDetectorSourceFilter and ExcludeLocalNodeFilter())
      * use explicit fullness checks instead of “any” check
    
    Simplify calculateStreamAndFetchRanges
    
    Unify request/transfer ranges interface (Added benefit of this change is that we have
a check for non-intersecting ranges)
    
    Improve error messages

commit 2b13c4a34b19a4de80eb60c9cd059b674a4b19d3
Author: Alex Petrov <oleksandr.petrov@...>
Date:   2018-09-17T12:17:33Z

    Switch dtest branch

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message