cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ifesdjeen <...@git.apache.org>
Subject [GitHub] cassandra pull request #278: Avoid running query to self through messaging s...
Date Mon, 08 Oct 2018 16:14:58 GMT
Github user ifesdjeen commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/278#discussion_r223421365
  
    --- Diff: src/java/org/apache/cassandra/net/MessagingService.java ---
    @@ -1078,7 +1078,7 @@ public void sendOneWay(MessageOut message, int id, InetAddressAndPort
to)
                 logger.trace("{} sending {} to {}@{}", FBUtilities.getBroadcastAddressAndPort(),
message.verb, id, to);
     
             if (to.equals(FBUtilities.getBroadcastAddressAndPort()))
    -            logger.trace("Message-to-self {} going over MessagingService", message);
    +            logger.warn("Message-to-self {} going over MessagingService", message);
    --- End diff --
    
    Right, we can do debug here. I wanted to first throw in this case, but then thought that
it's more useful to find all the cases where we still do that and eliminate those, since failing
in that case brings more or less nothing.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message