cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vinaykumarchella <...@git.apache.org>
Subject [GitHub] cassandra pull request #277: 12106 - blacklisting bad partitions for point r...
Date Mon, 08 Oct 2018 22:54:32 GMT
Github user vinaykumarchella commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/277#discussion_r223515773
  
    --- Diff: src/java/org/apache/cassandra/cache/BlacklistedPartitionCache.java ---
    @@ -0,0 +1,96 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.cassandra.cache;
    +
    +import java.util.Set;
    +import java.util.concurrent.TimeUnit;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import org.apache.cassandra.concurrent.ScheduledExecutors;
    +import org.apache.cassandra.config.DatabaseDescriptor;
    +import org.apache.cassandra.db.DecoratedKey;
    +import org.apache.cassandra.repair.SystemDistributedKeyspace;
    +import org.apache.cassandra.schema.TableId;
    +
    +/**
    + * Cache that loads blacklisted partitions from system_distributed.blacklisted_partitions
table
    + */
    +public class BlacklistedPartitionCache
    +{
    +    public final static BlacklistedPartitionCache instance = new BlacklistedPartitionCache();
    +    private static final Logger logger = LoggerFactory.getLogger(BlacklistedPartitionCache.class);
    +    private volatile Set<BlacklistedPartition> blacklistedPartitions;
    +
    +    private BlacklistedPartitionCache()
    +    {
    +        // setup a periodic refresh
    +        ScheduledExecutors.optionalTasks.scheduleWithFixedDelay(this::refreshCache,
    +                                                                DatabaseDescriptor.getBlacklistedPartitionsCacheRefreshInSec(),
    +                                                                DatabaseDescriptor.getBlacklistedPartitionsCacheRefreshInSec(),
    +                                                                TimeUnit.SECONDS);
    +    }
    +
    +    /**
    +     * Loads blacklisted partitions from system_distributed.blacklisted partitions table.
    +     * Also logs a warning if cache size exceeds the set threshold.
    +     */
    +    public void refreshCache()
    +    {
    +        this.blacklistedPartitions = SystemDistributedKeyspace.getBlacklistedPartitions();
    +
    +        // attempt to compute cache size only if there is a warn threshold configured
    +        if (DatabaseDescriptor.getBlackListedPartitionsCacheSizeWarnThresholdInMB() >
0)
    +        {
    +            long cacheSize = 0;
    +            for (BlacklistedPartition blacklistedPartition : blacklistedPartitions)
    +            {
    +                cacheSize += blacklistedPartition.unsharedHeapSize();
    +            }
    +
    +            if (cacheSize / (1024 * 1024) >= DatabaseDescriptor.getBlackListedPartitionsCacheSizeWarnThresholdInMB())
    +            {
    +                logger.warn(String.format("BlacklistedPartition cache size (%d) MB exceeds
threshold size (%d) MB", cacheSize / (1024 * 1024), DatabaseDescriptor.getBlackListedPartitionsCacheSizeWarnThresholdInMB()));
    --- End diff --
    
    You can avoid `String.format` inside logger and use the formatting specifiers directly


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message