cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aweisberg <...@git.apache.org>
Subject [GitHub] cassandra pull request #283: CASSANDRA-14459: DynamicEndpointSnitch should n...
Date Mon, 15 Oct 2018 22:34:26 GMT
Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/283#discussion_r225337690
  
    --- Diff: src/java/org/apache/cassandra/net/MessagingService.java ---
    @@ -665,9 +665,9 @@ public void updateBackPressureOnSend(InetAddressAndPort host, IAsyncCallback
cal
         /**
          * Updates the back-pressure state on reception from the given host if enabled and
the given message callback supports it.
          *
    -     * @param host The replica host the back-pressure state refers to.
    +     * @param host     The replica host the back-pressure state refers to.
    --- End diff --
    
    Your IDE is set up to fix whitespace on unchanged lines. That's generally not great just
because it introduces a lot of extra changes, and if two people have IDEs with different preferences
they end up fighting and introducing random conflicts all the time.
    
    Can you go through this change set and remove whitespace changes for things that haven't
actually been touched?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message