cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jolynch <...@git.apache.org>
Subject [GitHub] cassandra pull request #283: CASSANDRA-14459: DynamicEndpointSnitch should n...
Date Mon, 15 Oct 2018 23:21:44 GMT
Github user jolynch commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/283#discussion_r225347547
  
    --- Diff: src/java/org/apache/cassandra/net/IAsyncCallback.java ---
    @@ -31,11 +31,23 @@
         void response(MessageIn<T> msg);
     
         /**
    +     * @deprecated Use {@link #latencyMeasurementType()}. This is left for backwards
    +     *             compatibility with existing IAsyncCallback implementations but will
    +     *             be removed at a future date.
          * @return true if this callback is on the read path and its latency should be
          * given as input to the dynamic snitch.
          */
    +    @Deprecated
    --- End diff --
    
    Removing it will cause a lot of changes, I can do that but it will make the diff much
larger (I see about 20 files that would need changes)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message