cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jolynch <...@git.apache.org>
Subject [GitHub] cassandra pull request #283: CASSANDRA-14459: DynamicEndpointSnitch should n...
Date Mon, 15 Oct 2018 23:32:16 GMT
Github user jolynch commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/283#discussion_r225349554
  
    --- Diff: src/java/org/apache/cassandra/net/MessagingService.java ---
    @@ -665,9 +665,9 @@ public void updateBackPressureOnSend(InetAddressAndPort host, IAsyncCallback
cal
         /**
          * Updates the back-pressure state on reception from the given host if enabled and
the given message callback supports it.
          *
    -     * @param host The replica host the back-pressure state refers to.
    +     * @param host     The replica host the back-pressure state refers to.
    --- End diff --
    
    Interesting, I'm just using the default style guide for idea that came with Cassandra
(`ant generate-idea-files`). If it's just that review is tough you can tell github not to
show you whitespace changes.
    
    That's good feedback though that you don't want unrelated whitespace changes, I'll take
it out :-)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message