cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aweisberg <...@git.apache.org>
Subject [GitHub] cassandra pull request #283: CASSANDRA-14459: DynamicEndpointSnitch should n...
Date Mon, 10 Dec 2018 17:58:48 GMT
Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/283#discussion_r240299652
  
    --- Diff: src/java/org/apache/cassandra/locator/DynamicEndpointSnitch.java ---
    @@ -214,19 +600,27 @@ public String getDatacenter(InetAddressAndPort endpoint)
             {
                 if (subsnitchScore > (sortedScoreIterator.next() * (1.0 + dynamicBadnessThreshold)))
                 {
    -                return sortedByProximityWithScore(address, replicas);
    +                return sortedByProximityWithScore(address, replicas, aliasedScores);
                 }
             }
     
             return replicas;
         }
     
         // Compare endpoints given an immutable snapshot of the scores
    -    private int compareEndpoints(InetAddressAndPort target, Replica a1, Replica a2, Map<InetAddressAndPort,
Double> scores)
    +    public int compareEndpoints(InetAddressAndPort target, Replica a1, Replica a2)
    --- End diff --
    
    This comment seems wrong and the entire scenario is a little confusing?
    Why can't this be removed?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message