cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aweisberg <...@git.apache.org>
Subject [GitHub] cassandra pull request #283: CASSANDRA-14459: DynamicEndpointSnitch should n...
Date Mon, 10 Dec 2018 17:58:48 GMT
Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/283#discussion_r240308899
  
    --- Diff: src/java/org/apache/cassandra/service/StorageServiceMBean.java ---
    @@ -463,21 +463,33 @@
         public Map<String, String> getViewBuildStatusesWithPort(String keyspace, String
view);
     
         /**
    -     * Change endpointsnitch class and dynamic-ness (and dynamic attributes) at runtime.
    +     * Change endpointsnitch class and dynamicsnitch class at runtime.
          *
          * This method is used to change the snitch implementation and/or dynamic snitch
parameters.
          * If {@code epSnitchClassName} is specified, it will configure a new snitch instance
and make it a
    -     * 'dynamic snitch' if {@code dynamic} is specified and {@code true}.
    +     * 'dynamic snitch' if {@code dynamicSnitchClassName} is not null.
          *
    -     * The parameters {@code dynamicUpdateInterval}, {@code dynamicResetInterval} and
{@code dynamicBadnessThreshold}
    +     * The parameters {@code dynamicUpdateInterval}, {@code dynamicSampleUpdateInterval}
and {@code dynamicBadnessThreshold}
          * can be specified individually to update the parameters of the dynamic snitch during
runtime.
          *
    -     * @param epSnitchClassName        the canonical path name for a class implementing
IEndpointSnitch
    -     * @param dynamic                  boolean that decides whether dynamicsnitch is
used or not - only valid, if {@code epSnitchClassName} is specified
    -     * @param dynamicUpdateInterval    integer, in ms (defaults to the value configured
in cassandra.yaml, which defaults to 100)
    -     * @param dynamicResetInterval     integer, in ms (defaults to the value configured
in cassandra.yaml, which defaults to 600,000)
    -     * @param dynamicBadnessThreshold  double, (defaults to the value configured in cassandra.yaml,
which defaults to 0.0)
    +     * @param epSnitchClassName            the canonical path name for a class implementing
IEndpointSnitch or null.
    +     *                                     If null then no snitch change is made. If
an empty string the existing
    +     *                                     Snitch class is used.
    +     * @param dynamicSnitchClassName       the canonical path name for a class extending
DynamicEndpointSnitch. If
    +     *                                     null while epSnitchClassName is not null,
this turns off dynamic snitching;
    +     *                                     otherwise just settings are updated. If an
empty string is passed then
    +     *                                     dynamic snitching is kept with the default
implementation.
    +     * @param dynamicUpdateInterval        integer, in ms (defaults to the value configured
in cassandra.yaml, which defaults to 100)
    +     * @param dynamicSampleUpdateInterval  integer, in ms (defaults to the value configured
in cassandra.yaml, which defaults to 1,000)
    --- End diff --
    
    Documenting defaults in too many locations means the docs are likely to be obsoleted.
Such as when you fix the bug with the probe rate.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message