cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dineshjoshi <...@git.apache.org>
Subject [GitHub] cassandra-dtest pull request #41: 14421
Date Tue, 11 Dec 2018 23:18:45 GMT
Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra-dtest/pull/41#discussion_r240827140
  
    --- Diff: upgrade_tests/paging_test.py ---
    @@ -457,21 +458,30 @@ def test_basic_paging(self):
                 );
             """)
     
    -        cursor.execute("""
    -            CREATE TABLE test2 (
    -                k int,
    -                c int,
    -                v text,
    -                PRIMARY KEY (k, c)
    -            ) WITH COMPACT STORAGE;
    -        """)
    +        testing_compact_storage = self.cluster.version() < '4.0'
    +        if testing_compact_storage:
    +            cursor.execute("""
    +                CREATE TABLE test2 (
    +                    k int,
    +                    c int,
    +                    v text,
    +                    PRIMARY KEY (k, c)
    +                ) WITH COMPACT STORAGE;
    +            """)
    +
    +        version_string = self.upgrade_version_string()
    +        #4.0 doesn't support compact storage
    +        if version_string == 'trunk' or version_string >= '4.0':
    --- End diff --
    
    Use {{LooseVersion}} here as well?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message