cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dineshjoshi <...@git.apache.org>
Subject [GitHub] cassandra-dtest pull request #41: 14421
Date Tue, 11 Dec 2018 23:18:45 GMT
Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra-dtest/pull/41#discussion_r240823966
  
    --- Diff: sstable_generation_loading_test.py ---
    @@ -27,45 +27,68 @@ def fixture_add_additional_log_patterns(self, fixture_dtest_setup):
             fixture_dtest_setup.allow_log_errors = True
     
         upgrade_from = None
    -    compact = False
    +    test_compact = False
    +
    +    def compact(self):
    +        return self.fixture_dtest_setup.cluster.version() < '4' and self.test_compact
    --- End diff --
    
    Use `LooseVersion` instead of a string?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message