cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dineshjoshi <...@git.apache.org>
Subject [GitHub] cassandra-dtest pull request #41: 14421
Date Tue, 11 Dec 2018 23:18:45 GMT
Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra-dtest/pull/41#discussion_r240824209
  
    --- Diff: sstable_generation_loading_test.py ---
    @@ -141,6 +166,16 @@ def load_sstable_with_configuration(self, pre_compression=None, post_compression
                 session.execute("UPDATE standard1 SET v='{}' WHERE KEY='{}' AND c='col'".format(i,
i))
                 session.execute("UPDATE counter1 SET v=v+1 WHERE KEY='{}'".format(i))
     
    +        #Will upgrade to a version that doesn't support compact storage so revert the
compact
    +        #storage, this doesn't actually fix it yet
    +        if self.compact() and default_install_version >= '4':
    --- End diff --
    
    Use `LooseVersion` here as well? Prefer constants over magic strings / numbers.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message