cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dineshjoshi <...@git.apache.org>
Subject [GitHub] cassandra-dtest pull request #41: 14421
Date Tue, 11 Dec 2018 23:18:45 GMT
Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra-dtest/pull/41#discussion_r240827292
  
    --- Diff: upgrade_tests/storage_engine_upgrade_test.py ---
    @@ -140,6 +139,10 @@ def upgrade_with_clustered_table(self, compact_storage=False):
                 for r in range(ROWS):
                     session.execute("INSERT INTO t(k, t, v) VALUES ({n}, {r}, {r})".format(n=n,
r=r))
     
    +        #4.0 doesn't support compact storage
    +        if compact_storage and self.dtest_config.cassandra_version_from_build > '4':
    --- End diff --
    
    Use {{LooseVersion}} here as well?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message