cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dineshjoshi <...@git.apache.org>
Subject [GitHub] cassandra-dtest pull request #41: 14421
Date Thu, 20 Dec 2018 10:16:10 GMT
Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra-dtest/pull/41#discussion_r243218570
  
    --- Diff: upgrade_tests/upgrade_through_versions_test.py ---
    @@ -794,31 +800,33 @@ def create_upgrade_class(clsname, version_metas, protocol_version,
     MultiUpgrade = namedtuple('MultiUpgrade', ('name', 'version_metas', 'protocol_version',
'extra_config'))
     
     MULTI_UPGRADES = (
    -    # Proto v3 upgrades (v3 is supported on 2.1, 2.2, 3.0, 3.1, trunk)
    -    MultiUpgrade(name='TestProtoV3Upgrade_AllVersions_EndsAt_Trunk_HEAD',
    -                 version_metas=[current_2_1_x, current_2_2_x, current_3_0_x, indev_3_x],
protocol_version=3, extra_config=None),
    -    MultiUpgrade(name='TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_Trunk_HEAD',
    -                 version_metas=[current_2_1_x, current_2_2_x, current_3_0_x, indev_3_x],
protocol_version=3,
    +    # Proto v3 upgrades (v3 is supported on 2.1, 2.2, 3.0, 3.11)
    +    MultiUpgrade(name='TestProtoV3Upgrade_AllVersions_EndsAt_3_11_X',
    +                 version_metas=[current_2_1_x, current_2_2_x, current_3_0_x, indev_3_11_x],
protocol_version=3, extra_config=None),
    +    MultiUpgrade(name='TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD',
    +                 version_metas=[current_2_1_x, current_2_2_x, current_3_0_x, indev_3_11_x],
protocol_version=3,
                      extra_config=(
                          ('partitioner', 'org.apache.cassandra.dht.RandomPartitioner'),
                      )),
     
         # Proto v4 upgrades (v4 is supported on 2.2, 3.0, 3.1, trunk)
         MultiUpgrade(name='TestProtoV4Upgrade_AllVersions_EndsAt_Trunk_HEAD',
    -                 version_metas=[current_2_2_x, current_3_0_x, indev_3_x, ], protocol_version=4,
extra_config=None),
    +                 version_metas=[current_2_2_x, current_3_0_x, current_3_11_x, indev_trunk],
protocol_version=4, extra_config=None),
         MultiUpgrade(name='TestProtoV4Upgrade_AllVersions_RandomPartitioner_EndsAt_Trunk_HEAD',
    -                 version_metas=[current_2_2_x, current_3_0_x, indev_3_x], protocol_version=4,
    +                 version_metas=[current_2_2_x, current_3_0_x, current_3_11_x, indev_trunk],
protocol_version=4,
                      extra_config=(
                          ('partitioner', 'org.apache.cassandra.dht.RandomPartitioner'),
                      )),
    +    #Beta versions don't work with this test since it doesn't specify use beta in the
client
    +    #It's fine I guess for now? Can update on release
         # Proto v5 upgrades (v5 is supported on 3.0, 3.11, trunk)
    -    MultiUpgrade(name='TestProtoV5Upgrade_AllVersions_EndsAt_Trunk_HEAD',
    -                 version_metas=[current_3_0_x, current_3_x, indev_trunk], protocol_version=5,
extra_config=None),
    -    MultiUpgrade(name='TestProtoV5Upgrade_AllVersions_RandomPartitioner_EndsAt_Trunk_HEAD',
    -                 version_metas=[current_3_0_x, current_3_x, indev_trunk], protocol_version=5,
    -                 extra_config=(
    -                     ('partitioner', 'org.apache.cassandra.dht.RandomPartitioner'),
    -                 )),
    +    # MultiUpgrade(name='TestProtoV5Upgrade_AllVersions_EndsAt_Trunk_HEAD',
    --- End diff --
    
    Do we want to leave commented code in? It is ok if this is transient and we'll eventually
remove it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message