cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jolynch commented on a change in pull request #283: CASSANDRA-14459: DynamicEndpointSnitch should never prefer latent replicas
Date Tue, 29 Jan 2019 02:18:03 GMT
jolynch commented on a change in pull request #283: CASSANDRA-14459: DynamicEndpointSnitch
should never prefer latent replicas
URL: https://github.com/apache/cassandra/pull/283#discussion_r251669803
 
 

 ##########
 File path: src/java/org/apache/cassandra/net/ResponseVerbHandler.java
 ##########
 @@ -49,7 +49,7 @@ public void doVerb(MessageIn message, int id)
         else
         {
             //TODO: Should we add latency only in success cases?
 
 Review comment:
   What do you think we should record as the latency under a failure case? Timeouts are already
handled elsewhere, so we're just left with execution failures. A failure counting as a timeout
seems the most reasonable choice (as nodes that are throwing failures would very rapidly be
de-preferred), but not sure.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message