cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jolynch commented on a change in pull request #283: CASSANDRA-14459: DynamicEndpointSnitch should never prefer latent replicas
Date Tue, 29 Jan 2019 02:19:25 GMT
jolynch commented on a change in pull request #283: CASSANDRA-14459: DynamicEndpointSnitch
should never prefer latent replicas
URL: https://github.com/apache/cassandra/pull/283#discussion_r251670063
 
 

 ##########
 File path: src/java/org/apache/cassandra/service/StorageServiceMBean.java
 ##########
 @@ -463,21 +463,33 @@
     public Map<String, String> getViewBuildStatusesWithPort(String keyspace, String
view);
 
     /**
-     * Change endpointsnitch class and dynamic-ness (and dynamic attributes) at runtime.
+     * Change endpointsnitch class and dynamicsnitch class at runtime.
      *
      * This method is used to change the snitch implementation and/or dynamic snitch parameters.
      * If {@code epSnitchClassName} is specified, it will configure a new snitch instance
and make it a
-     * 'dynamic snitch' if {@code dynamic} is specified and {@code true}.
+     * 'dynamic snitch' if {@code dynamicSnitchClassName} is not null.
      *
-     * The parameters {@code dynamicUpdateInterval}, {@code dynamicResetInterval} and {@code
dynamicBadnessThreshold}
+     * The parameters {@code dynamicUpdateInterval}, {@code dynamicSampleUpdateInterval}
and {@code dynamicBadnessThreshold}
      * can be specified individually to update the parameters of the dynamic snitch during
runtime.
      *
-     * @param epSnitchClassName        the canonical path name for a class implementing IEndpointSnitch
-     * @param dynamic                  boolean that decides whether dynamicsnitch is used
or not - only valid, if {@code epSnitchClassName} is specified
-     * @param dynamicUpdateInterval    integer, in ms (defaults to the value configured in
cassandra.yaml, which defaults to 100)
-     * @param dynamicResetInterval     integer, in ms (defaults to the value configured in
cassandra.yaml, which defaults to 600,000)
-     * @param dynamicBadnessThreshold  double, (defaults to the value configured in cassandra.yaml,
which defaults to 0.0)
+     * @param epSnitchClassName            the canonical path name for a class implementing
IEndpointSnitch or null.
+     *                                     If null then no snitch change is made. If an empty
string the existing
+     *                                     Snitch class is used.
+     * @param dynamicSnitchClassName       the canonical path name for a class extending
DynamicEndpointSnitch. If
+     *                                     null while epSnitchClassName is not null, this
turns off dynamic snitching;
+     *                                     otherwise just settings are updated. If an empty
string is passed then
+     *                                     dynamic snitching is kept with the default implementation.
+     * @param dynamicUpdateInterval        integer, in ms (defaults to the value configured
in cassandra.yaml, which defaults to 100)
+     * @param dynamicSampleUpdateInterval  integer, in ms (defaults to the value configured
in cassandra.yaml, which defaults to 1,000)
 
 Review comment:
   yeah these defaults aren't even right ... tech debt --
   
   Removing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message