cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jolynch commented on a change in pull request #283: CASSANDRA-14459: DynamicEndpointSnitch should never prefer latent replicas
Date Tue, 29 Jan 2019 02:22:47 GMT
jolynch commented on a change in pull request #283: CASSANDRA-14459: DynamicEndpointSnitch
should never prefer latent replicas
URL: https://github.com/apache/cassandra/pull/283#discussion_r251670562
 
 

 ##########
 File path: test/unit/org/apache/cassandra/locator/DynamicEndpointSnitchTest.java
 ##########
 @@ -18,35 +18,99 @@
 
 package org.apache.cassandra.locator;
 
-import java.io.IOException;
+import java.net.UnknownHostException;
 
 Review comment:
   > but it would be good if it validated somewhere the futures are cleaned up and there
are no scheduled/running tasks in the executors.
   
   ack, writing that
   
   > but is sendPingMessage tested? Is it possible?
   
   It's not tested because it'll require the MessagingService, but I can just setup some sinks
for testing. Working on it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message