cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dineshjoshi <...@git.apache.org>
Subject [GitHub] cassandra-dtest pull request #41: 14421
Date Tue, 08 Jan 2019 00:59:13 GMT
Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra-dtest/pull/41#discussion_r245846129
  
    --- Diff: conftest.py ---
    @@ -409,13 +429,16 @@ def pytest_collection_modifyitems(items, config):
         This function is called upon during the pytest test collection phase and allows for
modification
         of the test items within the list
         """
    -    if not config.getoption("--collect-only") and config.getoption("--cassandra-dir")
is None:
    -        if config.getoption("--cassandra-version") is None:
    +    collect_only = config.getoption("--collect-only")
    +    cassandra_dir = config.getoption("--cassandra-dir")
    +    cassandra_version = config.getoption("--cassandra-version")
    +    if not collect_only and cassandra_dir  is None:
    +        if  cassandra_version is None:
    --- End diff --
    
    Nit: Extra space `if  cassandra_version`. Please fix on commit.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message