cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra-sidecar] clohfink commented on a change in pull request #3: Add integration tests task for CASSANDRA-15031
Date Mon, 04 Mar 2019 15:20:32 GMT
clohfink commented on a change in pull request #3: Add integration tests task for CASSANDRA-15031
URL: https://github.com/apache/cassandra-sidecar/pull/3#discussion_r262104275
 
 

 ##########
 File path: checkstyle.xml
 ##########
 @@ -0,0 +1,393 @@
+<?xml version="1.0" encoding="UTF-8"?>
 
 Review comment:
   they are hand crafted, cassandra has a unique code style requirement: https://cassandra.apache.org/doc/latest/development/code_style.html
   
   if we could use googles style id rather just run the style auto formatter on git commit
so we just didnt have to think about it anymore but since we have to match a kinda 1-off thing
this is best option i could find to maintain it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message