cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] kallelzied commented on a change in pull request #244: Refactor and add samplers for CASSANDRA-14436
Date Wed, 26 Jun 2019 13:10:59 GMT
kallelzied commented on a change in pull request #244: Refactor and add samplers for CASSANDRA-14436
URL: https://github.com/apache/cassandra/pull/244#discussion_r297655850
 
 

 ##########
 File path: src/java/org/apache/cassandra/db/ReadExecutionController.java
 ##########
 @@ -113,6 +123,11 @@ static ReadExecutionController forCommand(ReadCommand command)
                 throw e;
             }
         }
+        if (baseCfs.metric.topLocalReadQueryTime.isEnabled())
+        {
 
 Review comment:
   > Single line if conditions don't need braces.
   
   In this case it is better to write braces for readability issues even that we don't need
them 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message