cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra-sidecar] dineshjoshi commented on a change in pull request #4: Virtual tables API endpoints for sidecar for CASSANDRA-15124
Date Thu, 22 Aug 2019 18:29:41 GMT
dineshjoshi commented on a change in pull request #4: Virtual tables API endpoints for sidecar
for CASSANDRA-15124
URL: https://github.com/apache/cassandra-sidecar/pull/4#discussion_r316813331
 
 

 ##########
 File path: api.yaml
 ##########
 @@ -15,6 +15,130 @@ tags:
     description: Execute, coordinate, or schedule operations
 
 paths:
+  /api/v1/threadpools:
 
 Review comment:
   Is there a way we could auto-generate this spec. In the past I've used Django REST Framework
which autogenerated the docs and schemas - https://www.django-rest-framework.org/topics/documenting-your-api/
. Quick search turned up this: https://github.com/outofcoffee/vertx-oas The reason we should
consider doing this is, unless we're very diligent about keeping schemas in sync with the
actual routes, the spec gets stale and goes out of sync from the APIs. Alternatively, we should
maybe have a test that will check whether the schema is in conformance with the APIs. WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message