cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra-sidecar] dineshjoshi commented on a change in pull request #4: Virtual tables API endpoints for sidecar for CASSANDRA-15124
Date Thu, 22 Aug 2019 18:29:42 GMT
dineshjoshi commented on a change in pull request #4: Virtual tables API endpoints for sidecar
for CASSANDRA-15124
URL: https://github.com/apache/cassandra-sidecar/pull/4#discussion_r316815226
 
 

 ##########
 File path: src/main/java/org/apache/cassandra/sidecar/CQLSession.java
 ##########
 @@ -73,19 +98,66 @@ public synchronized Session getLocalCql()
         {
             if (localSession == null)
             {
-                cluster = Cluster.builder()
-                                 .addContactPointsWithPorts(inet)
-                                 .withLoadBalancingPolicy(wlp)
-                                 .withQueryOptions(queryOptions)
-                                 .withReconnectionPolicy(reconnectionPolicy)
-                                 .withoutMetrics()
-                                 // tests can create a lot of these Cluster objects, to avoid
creating HWTs and
-                                 // event thread pools for each we have the override
-                                 .withNettyOptions(nettyOptions)
-                                 .build();
+                Cluster.Builder builder = Cluster.builder()
+                                                 .addContactPointsWithPorts(address)
+                                                 .withLoadBalancingPolicy(wlp)
+                                                 .withQueryOptions(queryOptions)
+                                                 .withReconnectionPolicy(reconnectionPolicy)
+                                                 .withoutMetrics()
+                                                 // tests can create a lot of these Cluster
objects, to avoid creating
+                                                 // HWTs and event thread pools for each
we have the override
+                                                 .withNettyOptions(nettyOptions);
+
+                if (useSSL)
+                {
+                    try
+                    {
+                        if (trustStorePath != null && trustStorePassword != null)
 
 Review comment:
   I think this might be required for future tests as well. Perhaps consider adding this into
a utility class?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message