cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra-sidecar] dineshjoshi commented on a change in pull request #4: Virtual tables API endpoints for sidecar for CASSANDRA-15124
Date Thu, 22 Aug 2019 18:29:42 GMT
dineshjoshi commented on a change in pull request #4: Virtual tables API endpoints for sidecar
for CASSANDRA-15124
URL: https://github.com/apache/cassandra-sidecar/pull/4#discussion_r316823375
 
 

 ##########
 File path: src/main/java/org/apache/cassandra/sidecar/routes/HealthCheck.java
 ##########
 @@ -64,7 +64,7 @@ private boolean check()
                 return result;
             }
         }
-        catch (NoHostAvailableException nha)
+        catch (NoHostAvailableException | ConnectionException nha)
         {
             logger.trace("NoHostAvailableException in HealthCheck - Cassandra Down");
 
 Review comment:
   This message needs to change. Could you also add the exception to the logger so it prints
the stacktrace in the logs?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message