cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra-sidecar] dineshjoshi commented on a change in pull request #4: Virtual tables API endpoints for sidecar for CASSANDRA-15124
Date Thu, 22 Aug 2019 18:29:42 GMT
dineshjoshi commented on a change in pull request #4: Virtual tables API endpoints for sidecar
for CASSANDRA-15124
URL: https://github.com/apache/cassandra-sidecar/pull/4#discussion_r316816265
 
 

 ##########
 File path: src/main/java/org/apache/cassandra/sidecar/MainModule.java
 ##########
 @@ -96,6 +97,12 @@ public Router vertxRouter(Vertx vertx, HealthService healthService)
 
         // API paths
         router.route().path("/api/v1/__health").handler(healthService::handleHealth);
+
+        router.route().path("/api/v1/compactions").handler(infoService::handleCompactions);
 
 Review comment:
   Perhaps consider changing the path to `/api/v1/info/compactions`? That way all actions
related to the `InfoService` are under the same path.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message