cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra-sidecar] tolbertam commented on a change in pull request #4: Virtual tables API endpoints for sidecar for CASSANDRA-15124
Date Thu, 05 Sep 2019 07:31:01 GMT
tolbertam commented on a change in pull request #4: Virtual tables API endpoints for sidecar
for CASSANDRA-15124
URL: https://github.com/apache/cassandra-sidecar/pull/4#discussion_r321112180
 
 

 ##########
 File path: src/main/java/org/apache/cassandra/sidecar/MainModule.java
 ##########
 @@ -83,7 +84,7 @@ public HttpServer vertxServer(Vertx vertx, Configuration conf, Router router)
 
     @Provides
     @Singleton
-    public Router vertxRouter(Vertx vertx, HealthService healthService)
+    public Router vertxRouter(Vertx vertx, HealthService healthService, InfoService infoService)
 
 Review comment:
   On another note I wonder if we should get rid of `docs/index.html` and promote swagger
up to docs, as it seems more useful than redoc and includes the examples.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message