cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] codacy-bot commented on a change in pull request #354: CASSANDRA-15319 against 2.2
Date Sun, 06 Oct 2019 19:17:13 GMT
codacy-bot commented on a change in pull request #354: CASSANDRA-15319 against 2.2
URL: https://github.com/apache/cassandra/pull/354#discussion_r331805578
 
 

 ##########
 File path: test/distributed/org/apache/cassandra/distributed/impl/InstanceConfig.java
 ##########
 @@ -43,11 +42,14 @@
     public final int num;
     public int num() { return num; }
 
+    private final NetworkTopology networkTopology;
+    public NetworkTopology networkTopology() { return networkTopology; }
+
     public final UUID hostId;
     public UUID hostId() { return hostId; }
     private final Map<String, Object> params = new TreeMap<>();
 
-    private EnumSet featureFlags;
+    private final EnumSet featureFlags;
 
 Review comment:
   ![Codacy](https://app.codacy.com/assets/images/favicon.png) Issue found: [Fields should
be declared at the top of the class, before any method declarations, constructors, initializers
or inner classes.](https://app.codacy.com/app/Wen1234/cassandra/pullRequest?prid=4274605)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message