cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] spuds51 commented on issue #361: Expose schema via new DESCRIBE CQL statement
Date Mon, 07 Oct 2019 12:34:58 GMT
spuds51 commented on issue #361: Expose schema via new DESCRIBE CQL statement
URL: https://github.com/apache/cassandra/pull/361#issuecomment-538988686
 
 
   
   UNSUBSCRIBE
   
   	-----------------------------------------From: "Codacy Bot" 
   To: "apache/cassandra"
   Cc: "Subscribed"
   Sent: Monday October 7 2019 8:24:07AM
   Subject: Re: [apache/cassandra] Expose schema via new DESCRIBE CQL
   statement (#361)
   
   	@CODACY-BOT commented on this pull request. 
   -------------------------
   
   	In test/unit/org/apache/cassandra/db/SchemaCQLHelperTest.java [1]: 
   
   	> + IndexMetadata.Kind.CUSTOM, +
   Collections.singletonMap(IndexTarget.CUSTOM_INDEX_OPTION_NAME,
   SASIIndex.class.getName())))); + + +
   SchemaLoader.createKeyspace(keyspace, KeyspaceParams.simple(1),
   builder); + + ColumnFamilyStore cfs =
   Keyspace.open(keyspace).getColumnFamilyStore(table); + +
   assertEquals(ImmutableList.of("CREATE INDEX "indexName" ON
   cql_test_keyspace_3.test_table_3 (values(reg1));", + "CREATE INDEX
   "indexName2" ON cql_test_keyspace_3.test_table_3 (keys(reg1));", +
   "CREATE INDEX "indexName3" ON cql_test_keyspace_3.test_table_3
   (entries(reg1));", + "CREATE CUSTOM INDEX "indexName4" ON
   cql_test_keyspace_3.test_table_3 (entries(reg1)) USING
   'org.apache.cassandra.index.sasi.SASIIndex';"), +
   SchemaCQLHelper.getIndexesAsCQL(cfs.metadata()).collect(Collectors.toList()));
   + } + + private final static String SNAPSHOT = "testsnapshot";  
   
   	 [2] Issue found: Fields should be declared at the top of the class,
   before any method declarations, constructors, initializers or inner
   classes. [3] 
   
   	—
   You are receiving this because you are subscribed to this thread.
   Reply to this email directly, view it on GitHub [4], or mute the
   thread [5]. 
   
   Links:
   ------
   [1] https://github.com/apache/cassandra/pull/361#discussion_r331987575
   [2]
   https://camo.githubusercontent.com/b72992711a855bd9a03bfbdfc5ef7fcf528482f5/68747470733a2f2f6170702e636f646163792e636f6d2f6173736574732f696d616765732f66617669636f6e2e706e67
   [3]
   https://app.codacy.com/app/Wen1234/cassandra/pullRequest?prid=4274613
   [4]
   https://github.com/apache/cassandra/pull/361?email_source=notifications&email_token=ADEDDZUM3UVUKA735QY4WSTQNMS6PA5CNFSM4IYWJMM2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHCHC7Y#pullrequestreview-298086783
   [5]
   https://github.com/notifications/unsubscribe-auth/ADEDDZQHOA2HUKUNMZCAUGDQNMS6PANCNFSM4IYWJMMQ
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message