cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] openrefactory opened a new pull request #367: Suggested fixes by iCR, OpenRefactory, Inc.
Date Fri, 18 Oct 2019 12:22:49 GMT
openrefactory opened a new pull request #367: Suggested fixes by iCR, OpenRefactory, Inc.
URL: https://github.com/apache/cassandra/pull/367
 
 
   OpenRefactory introduces fixers, that automatically fix safety, security, reliability and
compliance issues. We ran OpenRefactory's Intelligent Code Repair (iCR) analysis engine on
your code. We are reporting a few sample fixes that were generated.
   The goal of the this fix is to resolve  Zero Division Check, Unexpected Control Flow and
Weak Library Usage problem. 
   
   **Zero Division Check Fixes:**
    
   In file: `Duration.java`, class:` Duration`, method: `append` , there is a potential Division
By Zero error while running. iCR suggested changes in 1 files to resolve the problem.
   
   In file: `CommitLog.java`, class: `CommitLog`, method: `getActiveSegmentCompressionRatios`
,  there is a potential Division By Zero error while running. iCR suggested changes in 1 files
to resolve the problem.
   
   In file: `SizeTieredCompactionStrategy.java`, class: `SizeTieredCompactionStrategy,` method:
`getEstimatedCompactionsByTasks `, there is a potential Division By Zero error while running.
iCR suggested changes in 1 files to resolve the problem.
   
   In file: `Upgrader.java`, class: `Upgrader`, method:` Upgrader`,  there is a potential
Division By Zero error while running. iCR suggested changes in 1 files to resolve the problem.
   
   In file:` MajorLeveledCompactionWriter.java`, class: `MajorLeveledCompactionWriter`, method:
`MajorLeveledCompactionWriter`, there is a potential Division By Zero error while running.
iCR suggested changes in 1 files to resolve the problem.
   
   In file: `MaxSSTableSizeWriter.java`, class: `MaxSSTableSizeWriter`, method: `MaxSSTableSizeWriter`
, there is a potential Division By Zero error while running. iCR suggested changes in 1 files
to resolve the problem.
   
   In file: `StorageProxy.java`, class:` StorageProxy`, method: `estimateResultsPerRange `,
there is a potential Division By Zero error while running. iCR suggested changes in 1 files
to resolve the problem.
   
   The fix addresses CWE 369
   
   **Unexpected Control Flow Fixes:**
   
   In file: `AbstractTypeVersionComparator.java`, class: `AbstractTypeVersionComparator`,
method: `compareCompositeTypes`  has a semicolon at an unusual place . iCR suggested changes
in 1 files to resolve the problem.
   
   **Weak Library Usage Fixes:**
   
   In file: `UUIDGen.java`, class: `UUIDGen`, method:` hash ` uses Random object but it may
not be truly random. It should be replaced with SecureRandom. . iCR suggested changes in 1
files to resolve the problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message