cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] dcapwell commented on a change in pull request #388: CASSANDRA-15429: Support NodeTool in dtest
Date Tue, 10 Dec 2019 19:21:38 GMT
dcapwell commented on a change in pull request #388: CASSANDRA-15429: Support NodeTool in dtest
URL: https://github.com/apache/cassandra/pull/388#discussion_r356229705
 
 

 ##########
 File path: src/java/org/apache/cassandra/tools/NodeTool.java
 ##########
 @@ -46,7 +47,20 @@
 {
     private static final String HISTORYFILE = "nodetool.history";
 
+    private static NodeProbeFactory nodeProbeFactory = new NodeProbeFactory();
 
 Review comment:
   or make execute a instance method and provide this in the `NodeTool` constructor, so main
is `new NodeTool().execute(args)` and dtest is `new NodeTool(override).execute(args)`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message