cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] yifan-c commented on a change in pull request #388: CASSANDRA-15429: Support NodeTool in dtest
Date Tue, 10 Dec 2019 19:35:15 GMT
yifan-c commented on a change in pull request #388: CASSANDRA-15429: Support NodeTool in dtest
URL: https://github.com/apache/cassandra/pull/388#discussion_r356236456
 
 

 ##########
 File path: src/java/org/apache/cassandra/tools/NodeProbe.java
 ##########
 @@ -1323,6 +1323,11 @@ public TabularData getFailureDetectorPhilValues()
             throw new RuntimeException(e);
         }
     }
+
+    public MessagingServiceMBean getMsProxy()
 
 Review comment:
   The method name, `getMsProxy`, is not good. The reason to do so is to follow the existing
method naming convention in the class. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message