cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] dcapwell commented on a change in pull request #388: CASSANDRA-15429: Support NodeTool in dtest
Date Tue, 10 Dec 2019 22:28:03 GMT
dcapwell commented on a change in pull request #388: CASSANDRA-15429: Support NodeTool in dtest
URL: https://github.com/apache/cassandra/pull/388#discussion_r356312440
 
 

 ##########
 File path: src/java/org/apache/cassandra/tools/NodeTool.java
 ##########
 @@ -46,7 +47,20 @@
 {
     private static final String HISTORYFILE = "nodetool.history";
 
+    private static NodeProbeFactory nodeProbeFactory = new NodeProbeFactory();
 
 Review comment:
   with a small change, you can get this without statics.
   
   by replacing our usage of `Runnable` with `Consumer<NodeProbeFactory>` (need to extend
`Help` to do this), we can replace `parse.run()` with `parse.accept(nodeProbeFactory)`.  Since
the usage is just the `connect` method, this won't change the different commands, and will
be local to `NodeToolCmd`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message