cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] dcapwell commented on a change in pull request #428: CASSANDRA-15505
Date Wed, 29 Jan 2020 18:19:53 GMT
dcapwell commented on a change in pull request #428: CASSANDRA-15505 
URL: https://github.com/apache/cassandra/pull/428#discussion_r372539598
 
 

 ##########
 File path: test/distributed/org/apache/cassandra/distributed/api/IMessageFilters.java
 ##########
 @@ -18,30 +18,37 @@
 
 package org.apache.cassandra.distributed.api;
 
-import org.apache.cassandra.net.MessagingService;
-import org.apache.cassandra.net.Verb;
+import java.io.Serializable;
 
 public interface IMessageFilters
 {
     public interface Filter
     {
-        Filter restore();
-        Filter drop();
+        Filter off();
+        Filter on();
     }
 
     public interface Builder
     {
         Builder from(int ... nums);
         Builder to(int ... nums);
-        Filter ready();
+        Builder messagesMatching(Matcher filter);
         Filter drop();
+        Filter pass();
     }
 
-    Builder verbs(Verb ... verbs);
+    public interface Matcher extends Serializable
 
 Review comment:
   since we don't transfer not needed but doesn't hurt.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message