cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] dcapwell commented on a change in pull request #435: repair token boundary in-jvm tests for CASSANDRA-15542
Date Wed, 05 Feb 2020 02:09:58 GMT
dcapwell commented on a change in pull request #435: repair token boundary in-jvm tests for
CASSANDRA-15542
URL: https://github.com/apache/cassandra/pull/435#discussion_r375026225
 
 

 ##########
 File path: src/java/org/apache/cassandra/utils/ByteBufferUtil.java
 ##########
 @@ -535,6 +535,8 @@ else if (obj instanceof InetAddress)
             return ByteBufferUtil.bytes((InetAddress) obj);
         else if (obj instanceof String)
             return ByteBufferUtil.bytes((String) obj);
+        else if (obj instanceof ByteBuffer)
 
 Review comment:
   spoke about this; its not used in this PR but adds the identity result to this function.
 Up to you if you want it or not.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message