cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] dcapwell commented on a change in pull request #446: CASSANDRA-15564 Refactor repair coordinator to centralize stage change logic and improved the public facing errors
Date Tue, 10 Mar 2020 17:04:53 GMT
dcapwell commented on a change in pull request #446: CASSANDRA-15564 Refactor repair coordinator
to centralize stage change logic and improved the public facing errors
URL: https://github.com/apache/cassandra/pull/446#discussion_r390470787
 
 

 ##########
 File path: src/java/org/apache/cassandra/service/ActiveRepairService.java
 ##########
 @@ -525,6 +525,20 @@ public synchronized ParentRepairSession removeParentRepairSession(UUID
parentSes
         return parentRepairSessions.remove(parentSessionId);
     }
 
+    public synchronized ParentRepairSession removeParentRepairSessionIfPresent(UUID parentSessionId)
 
 Review comment:
   they are the same minus the "don't fail if not present thing". The code that called `removeParentRepairSession`
assumes the session exists so would be an error it it doesn't, the new code which calls `removeParentRepairSessionIfPresent`
calls it during cases were the session may not be setup yet, so may see a null.
   
   I could refactor so the `removeParentRepairSession` calls this one and still fails, but
I didn't want to change the semantics of that method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message