cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra-builds] michaelsembwever commented on a change in pull request #14: CASSANDRA-15639 Jenkins build for jvm test should use testclasslist to support parameterized tests
Date Sat, 14 Mar 2020 13:11:00 GMT
michaelsembwever commented on a change in pull request #14: CASSANDRA-15639 Jenkins build for
jvm test should use testclasslist to support parameterized tests
URL: https://github.com/apache/cassandra-builds/pull/14#discussion_r392587322
 
 

 ##########
 File path: jenkins-dsl/cassandra_pipeline.groovy
 ##########
 @@ -40,7 +40,7 @@ pipeline {
             stage('JVM DTests') {
               steps {
                   warnError('Tests unstable') {
-                    build job: "${env.JOB_NAME}-test-jvm-dtest-forking", parameters: [string(name:
'REPO', value: params.REPO), string(name: 'BRANCH', value: params.BRANCH)]
+                    build job: "${env.JOB_NAME}-jvm-dtest", parameters: [string(name: 'REPO',
value: params.REPO), string(name: 'BRANCH', value: params.BRANCH)]
 
 Review comment:
   Could we just keep the name suffix as `-test-jvm-dtest-forking` for now, and come back
to changing it later on?
   Adding a `todo` comment to do the rename would be useful.
   
   (I suspect there will be other changes that involve updating both repositories, over multiple
branches, later on. and would rather just avoid it for now :( apologises for the confusion)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message