cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] michaelsembwever commented on a change in pull request #474: Add JAVA_HOME and java.rmi.server.randomID to the system_properties t…
Date Mon, 16 Mar 2020 18:00:12 GMT
michaelsembwever commented on a change in pull request #474: Add JAVA_HOME and java.rmi.server.randomID
to the system_properties t…
URL: https://github.com/apache/cassandra/pull/474#discussion_r393212273
 
 

 ##########
 File path: src/java/org/apache/cassandra/db/virtual/SystemPropertiesTable.java
 ##########
 @@ -80,6 +85,12 @@ public DataSet data()
     {
         SimpleDataSet result = new SimpleDataSet(metadata());
 
+        System.getenv().keySet()
+                .stream()
+                .filter(SystemPropertiesTable::isCassandraRelevant)
+                .forEach(name -> addRow(result, name, System.getenv(name)));
+        //addRow(result, "JAVA_HOME", System.getenv("JAVA_HOME"));
 
 Review comment:
   nit: the commented line can be removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message