cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] cthumuluru opened a new pull request #464: CASSANDRA-15397: Resubmitting the changes with proposed review comments.
Date Mon, 09 Mar 2020 01:31:56 GMT
cthumuluru opened a new pull request #464: CASSANDRA-15397: Resubmitting the changes with proposed
review comments. 
URL: https://github.com/apache/cassandra/pull/464
 
 
   @belliottsmith — I made necessary changes to IntervalList implementation based on the
feedback. The previous submission was moved to IntervalList2. I also refactored the other
code to use the IntervalList instead of IntervalTree. You suggested to use 4 long[] arrays
but I couldn't do so since the code uses a generic that is comparable. I'm not sure if assuming
long will be a good idea. Instead I changed the implementation to use two lists one to store
the interval points and the other to store the data. Based on my performance comparison, I
see the previous submission performs better. It could be partly because it packs all the relevant
data items together. I also added the performance comparison for 100k, 250, 500k, 750k and
1 million SSTables based on 1000 searches. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message