cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] plastikat opened a new pull request #467: cqlsh return non-zero status when STDIN CQL fails
Date Tue, 10 Mar 2020 08:07:59 GMT
plastikat opened a new pull request #467: cqlsh return non-zero status when STDIN CQL fails
URL: https://github.com/apache/cassandra/pull/467
 
 
   I believe currently it can be safely assumed that
   any `Shell` instance without a TTY (i.e. `Shell.tty
   == False`) is in a "batch mode". With this in mind,
   the two following changes were applied.
   
   First, while we could just use the `Shell.tty`
   attribute directly, to be semantically clear and to
   provide room for future enhancement on what is
   considered a "batch mode", we will add a respective
   property instead.
   
   Second, with the new `Shell.batch_mode` property at
   hand, it makes no more sense to check any options
   implying a "batch mode", it is perfectly enough to
   just check this property.
   
   patch by Jacob Becker a.k.a. plastikat;
   reviewed by Jordan West for CASSANDRA-15623

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message