cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] sbtourist commented on a change in pull request #497: Cassandra 15666 trunk
Date Thu, 02 Apr 2020 15:32:47 GMT
sbtourist commented on a change in pull request #497: Cassandra 15666 trunk
URL: https://github.com/apache/cassandra/pull/497#discussion_r402403657
 
 

 ##########
 File path: src/java/org/apache/cassandra/streaming/StreamSession.java
 ##########
 @@ -830,4 +893,56 @@ public int getNumTransfers()
     {
         return transferredRangesPerKeyspace.size();
     }
+
+    public static class MessageStateSink
+    {
+        // use enum ordinal instead of enum to walk around inter-jvm class loader issue,
only classes defined in
+        // InstanceClassLoader#sharedClassNames are shareable between server jvm and test
jvm
+        public final Map<InetAddress, Deque<Integer>> messageSink = new ConcurrentHashMap<>();
+        public final Map<InetAddress, Deque<Integer>> stateTransitions = new
ConcurrentHashMap<>();
+
+        private boolean skipKeepAlive = true;
 
 Review comment:
   Shouldn't these two be `volatile`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message