cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] stef1927 commented on a change in pull request #506: CASSANDRA-15679 Don't use bytearray for blobs in copyutil.py 4.0
Date Thu, 02 Apr 2020 18:50:04 GMT
stef1927 commented on a change in pull request #506: CASSANDRA-15679 Don't use bytearray for
blobs in copyutil.py 4.0
URL: https://github.com/apache/cassandra/pull/506#discussion_r402537088
 
 

 ##########
 File path: pylib/cqlshlib/copyutil.py
 ##########
 @@ -1933,7 +1933,10 @@ def convert_mandatory(t, v):
             return converters.get(t.typename, convert_unknown)(v, ct=t)
 
         def convert_blob(v, **_):
-            return bytearray.fromhex(v[2:])
+            if sys.version_info.major >= 3:
+                return bytes.fromhex(v[:2])
 
 Review comment:
   `2:`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message