cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] adelapena commented on a change in pull request #473: Cassandra 15369
Date Mon, 06 Apr 2020 14:49:11 GMT
adelapena commented on a change in pull request #473: Cassandra 15369
URL: https://github.com/apache/cassandra/pull/473#discussion_r404151805
 
 

 ##########
 File path: src/java/org/apache/cassandra/db/partitions/AbstractBTreePartition.java
 ##########
 @@ -205,12 +202,17 @@ private RowAndDeletionMergeIterator merge(Iterator<Row> rowIter,
Iterator<RangeT
                                                canHaveShadowedData());
     }
 
-    private abstract class AbstractIterator extends AbstractUnfilteredRowIterator
+    private class SlicesIterator extends AbstractUnfilteredRowIterator
     {
         final Holder current;
         final ColumnFilter selection;
 
-        private AbstractIterator(Holder current, Row staticRow, ColumnFilter selection, boolean
isReversed)
 
 Review comment:
   This removed `AbstractIterator`, without any change, could be the base class for both `SlicesIterator`
and the new `ClusteringsIterator`, so we can avoid some duplication, especially the long comment
about fetched columns.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message