cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] dineshjoshi commented on a change in pull request #519: CASSANDRA-15696 improve ideal CL tracking
Date Tue, 07 Apr 2020 01:07:35 GMT
dineshjoshi commented on a change in pull request #519: CASSANDRA-15696 improve ideal CL tracking
URL: https://github.com/apache/cassandra/pull/519#discussion_r404478074
 
 

 ##########
 File path: src/java/org/apache/cassandra/service/AbstractWriteResponseHandler.java
 ##########
 @@ -279,8 +291,9 @@ private final void decrementResponseOrExpired()
         int decrementedValue = responsesAndExpirations.decrementAndGet();
         if (decrementedValue == 0)
         {
-            //The condition being signaled is a valid proxy for the CL being achieved
-            if (!condition.isSignaled())
+            // The condition being signaled is a valid proxy for the CL being achieved
+            // Only mark it as failed if the requested CL was achieved.
+            if (!condition.isSignaled() & requestedCLAchieved)
 
 Review comment:
   Is this intentionally a bitwise AND?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message