cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] ifesdjeen commented on a change in pull request #539: CASSANDRA-15733 jvm dtest builder should be provided to the factory and expose state
Date Thu, 16 Apr 2020 11:47:43 GMT
ifesdjeen commented on a change in pull request #539: CASSANDRA-15733 jvm dtest builder should
be provided to the factory and expose state
URL: https://github.com/apache/cassandra/pull/539#discussion_r409493084
 
 

 ##########
 File path: test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java
 ##########
 @@ -241,26 +249,53 @@ public void uncaughtException(Thread thread, Throwable throwable)
         }
     }
 
-    protected AbstractCluster(File root, Versions.Version initialVersion, List<IInstanceConfig>
configs,
-                              ClassLoader sharedClassLoader)
+    protected AbstractCluster(AbstractBuilder builder)
 
 Review comment:
   Maybe something like `AbstractBuilder<I, ICluster<I>, ?> builder` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message