cassandra-pr mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cassandra] ifesdjeen commented on a change in pull request #539: CASSANDRA-15733 jvm dtest builder should be provided to the factory and expose state
Date Fri, 17 Apr 2020 09:10:00 GMT
ifesdjeen commented on a change in pull request #539: CASSANDRA-15733 jvm dtest builder should
be provided to the factory and expose state
URL: https://github.com/apache/cassandra/pull/539#discussion_r410080485
 
 

 ##########
 File path: test/distributed/org/apache/cassandra/distributed/test/TestBaseImpl.java
 ##########
 @@ -40,9 +38,9 @@ public static void beforeClass() throws Throwable {
     }
 
     @Override
-    public <I extends IInstance, C extends ICluster> Builder<I, C> builder()
{
+    public Cluster.Builder builder() {
 
 Review comment:
   We have erased types here, is there a good reason for that?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Mime
View raw message